@hansschuijff

1 year ago

Thanks Gio, after the previous lesson this was a walk in the park. Looking forward to the next one. 🙂 Just a few things I reacted to, mostly preference again and knowing it's being just demo code for teaching purposes. In my own version I would probably have refactored checking the URLs for the same host to it's own function or method, just so I don't have to think when I come back to the method after a while, just like using explanatory vars. I already have comparable functions in other code. It's just a preference of course. The methods are small enough so they are still easy enough to understand and when coming back to older code, it seems to always cost some time to remember the structure of it anyways. Am I right in thinking that when you use an assignment as a condition, it is basically processed as the equivalent of first doing the assignment and then using the resulting variable as a condition? We talked about it in the prev lesson and here you have used that pattern again. Just verifying if I understand it right. Probably calling the second flash argument messages isn't quite fitting, since it only fits the array of error messages it gets and not the form input values. Just a minor detail though. I'm always aware I forget such details when I get back to code in a year. But great lesson again Gio. You're a great teacher for me. Even how the frontend looks is quite slik and pro. Appreciate it a lot.

1 |